optimize ssh Feed function example #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢贡献！确实如果 LSM 增加 context 的话更好，只是这样就需要修改所有 analyzers 了。。
其实并不存在多线程问题，因为目前每个流是分配到一个固定的 worker 线程处理，对每个 analyzer 实例而言是单线程的 |
是这样的, 可以抽象化一个 context 出来, 可能工程量稍微比较大一点,好处就是比现在代码来讲相对好理解一点,可能从逻辑角度上更好理解一点,如果需要的话,我可以提交更多的 commit 来完成这一工作. 改完之后可以在处理流的过程中多线程处理. |
|
行呀，给 LSM 加上 context 吧 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我修改了其中的一个 Feed 函数, 觉得这样会比较好理解以及处理流比较清晰.
另外, 可以在 lsm 里面增加 LSMContext 处理结构,这样可以避免直接去处理流, 也可以避免一些多线程处理流的问题,如果需要的话, 我可以进行更改.